[
https://issues.apache.org/jira/browse/HDFS-3678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440913#comment-13440913
]
Eli Collins commented on HDFS-3678:
-----------------------------------
- Why not make JournalManager extend PurgeableEditsStorage? And maybe rename
PurgeableEditsStorage to PurgableLog?
- Seems better to refactor FSImage to take a NNStorageRetentionManager rather
than have CheckpointStorage create one via super then immediatley re-create it
- In purgeLogsOlderThan you can just check f.getLastTxId() < minTxIdToKeep
since EditLogFile first is always <= last.
- Nit: @param and @throws don't end w periods
- Nit: s/there's no/there are no/
> Edit log files are never being purged from 2NN
> ----------------------------------------------
>
> Key: HDFS-3678
> URL: https://issues.apache.org/jira/browse/HDFS-3678
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 3.0.0
> Reporter: Todd Lipcon
> Assignee: Aaron T. Myers
> Priority: Critical
> Attachments: HDFS-3678.patch
>
>
> Seeing the following NPE in the SecondaryNameNode when it tries to purge
> storage after a checkpoint:
> 12/07/17 19:05:22 WARN namenode.FSImage: Unable to purge old storage
> java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.server.namenode.FSEditLog.purgeLogsOlderThan(FSEditLog.java:1013)
> at
> org.apache.hadoop.hdfs.server.namenode.NNStorageRetentionManager.purgeOldStorage(NNStorageRetentionManager.java:98)
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.purgeOldStorage(FSImage.java:925)
> at
> org.apache.hadoop.hdfs.server.namenode.SecondaryNameNode.doCheckpoint(SecondaryNameNode.java:479)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
