[
https://issues.apache.org/jira/browse/HDFS-3678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron T. Myers updated HDFS-3678:
---------------------------------
Attachment: HDFS-3678.patch
Thanks a lot for the review, Eli. Thispatch addresses all of your comments
except for refactoring the FSImage constructor to take an
NNStorageRetentionManager. The difficulty with doing so is that the
NNStorageRetentionManager needs to take a reference to the edit log, which
itself is constructed in the FSImage constructor. I agree that doing it the way
I have here isn't the cleanest thing in the world, but I can't think of a
cleaner way to do it. This is also consistent with the nulling-out of the
editLog member that's also done in the SecondaryNameNode.
> Edit log files are never being purged from 2NN
> ----------------------------------------------
>
> Key: HDFS-3678
> URL: https://issues.apache.org/jira/browse/HDFS-3678
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 3.0.0
> Reporter: Todd Lipcon
> Assignee: Aaron T. Myers
> Priority: Critical
> Attachments: HDFS-3678.patch, HDFS-3678.patch
>
>
> Seeing the following NPE in the SecondaryNameNode when it tries to purge
> storage after a checkpoint:
> 12/07/17 19:05:22 WARN namenode.FSImage: Unable to purge old storage
> java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.server.namenode.FSEditLog.purgeLogsOlderThan(FSEditLog.java:1013)
> at
> org.apache.hadoop.hdfs.server.namenode.NNStorageRetentionManager.purgeOldStorage(NNStorageRetentionManager.java:98)
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.purgeOldStorage(FSImage.java:925)
> at
> org.apache.hadoop.hdfs.server.namenode.SecondaryNameNode.doCheckpoint(SecondaryNameNode.java:479)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
