[ 
https://issues.apache.org/jira/browse/HDFS-3540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448185#comment-13448185
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-3540:
----------------------------------------------

{quote}
>    Correct me if I am wrong: Recovery Mode without HDFS-3479 means the entire 
> end-of-log is not checked and, therefore, the silent data loss length is not 
> limited. It is even worst.

No, that is incorrect.

Recovery mode has always read up to the end of the log, and it always will. The 
confusion arises because sometimes we are not very good at determining where 
the "end of the log" is.
{quote}

I should be more specific: For Recovery Mode without HDFS-3479, if there is 
corruption in the middle of the edit log and the user chooses "stop reading" in 
recovery mode, then the remaining data of the edit log will not be checked.  Is 
it correct?
                
> Further improvement on recovery mode and edit log toleration in branch-1
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3540
>                 URL: https://issues.apache.org/jira/browse/HDFS-3540
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 1.2.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>
> *Recovery Mode*: HDFS-3479 backported HDFS-3335 to branch-1.  However, the 
> recovery mode feature in branch-1 is dramatically different from the recovery 
> mode in trunk since the edit log implementations in these two branch are 
> different.  For example, there is UNCHECKED_REGION_LENGTH in branch-1 but not 
> in trunk.
> *Edit Log Toleration*: HDFS-3521 added this feature to branch-1 to remedy 
> UNCHECKED_REGION_LENGTH and to tolerate edit log corruption.
> There are overlaps between these two features.  We study potential further 
> improvement in this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to