[ 
https://issues.apache.org/jira/browse/HDFS-3540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449369#comment-13449369
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-3540:
----------------------------------------------

Hi Colin, you keep mentioning HDFS-3004 or the recovery mode feature in trunk.  
However, we are talking about branch-1 recovery mode here.

> ... There's many more convincing process-based arguments. branch-1 is a 
> stable branch. We should be fixing bugs, not making major changes. We should 
> be trying to minimize the divergence between branch-1 and branch-2, not 
> amplify it. People already know how to use recovery mode. We're not going to 
> retrain people to use an (in my opinion more error-prone) system that does 
> the same thing.

The branch-1 recovery mode feature is not yet released.  If the new feature has 
problems, we should remove it.  It is not a point if people already know how to 
use it.  If there are people using development code, they have to get prepared 
that the un-released new feature may be changed or removed.

Also, we don't not have to minimize the divergence between branch-1 and 
branch-2.  We usually add new features to branch-2 but not branch-1.
                
> Further improvement on recovery mode and edit log toleration in branch-1
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3540
>                 URL: https://issues.apache.org/jira/browse/HDFS-3540
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 1.2.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>
> *Recovery Mode*: HDFS-3479 backported HDFS-3335 to branch-1.  However, the 
> recovery mode feature in branch-1 is dramatically different from the recovery 
> mode in trunk since the edit log implementations in these two branch are 
> different.  For example, there is UNCHECKED_REGION_LENGTH in branch-1 but not 
> in trunk.
> *Edit Log Toleration*: HDFS-3521 added this feature to branch-1 to remedy 
> UNCHECKED_REGION_LENGTH and to tolerate edit log corruption.
> There are overlaps between these two features.  We study potential further 
> improvement in this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to