[ 
https://issues.apache.org/jira/browse/HDFS-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458259#comment-13458259
 ] 

Todd Lipcon commented on HDFS-3950:
-----------------------------------

Actually I thought to grep the cluster fault injection test log output for 
AssertionError and there is an edge case here due to the following:
bq. Adds a fault injection point between where a logger downloads a log segment 
and then persists the metadata about that log segment. I had a hunch there 
might be a bug here, but it is successfully passing the tests, so I think it 
turned out to not be a problem. The new fault injection point uses the same 
strategy as CheckpointFaultInjector.

So my hunch was right. Looking into how best to fix this super-rare edge case. 
It's still worth reviewing this patch in the interim though
                
> QJM: misc TODO cleanup, improved log messages, etc
> --------------------------------------------------
>
>                 Key: HDFS-3950
>                 URL: https://issues.apache.org/jira/browse/HDFS-3950
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: QuorumJournalManager (HDFS-3077)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-3950.txt
>
>
> General JIRA for a bunch of miscellaneous clean-up in the QJM branch:
> - fix most remaining TODOs
> - improve some log/error messages
> - add some more sanity checks where appropriate
> - address any findbugs that might have crept into branch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to