[ 
https://issues.apache.org/jira/browse/HDFS-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458958#comment-13458958
 ] 

Todd Lipcon commented on HDFS-3950:
-----------------------------------

bq. Worth making the output buffer size configurable vs hard-coding to 512k 
while you're at it?

With this patch, it respects whatever is passed in from FSEditLog. Currently 
that's hard-coded from there. If we want to change it to be configurable, it 
should be a system-wide change, rather than QJM-specific, so I'd rather not do 
it in this patch. 512kb per output stream still seems reasonable, given even a 
highly redundant NN setup would only have 5 or 7.
                
> QJM: misc TODO cleanup, improved log messages, etc
> --------------------------------------------------
>
>                 Key: HDFS-3950
>                 URL: https://issues.apache.org/jira/browse/HDFS-3950
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: QuorumJournalManager (HDFS-3077)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-3950.txt, hdfs-3950.txt
>
>
> General JIRA for a bunch of miscellaneous clean-up in the QJM branch:
> - fix most remaining TODOs
> - improve some log/error messages
> - add some more sanity checks where appropriate
> - address any findbugs that might have crept into branch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to