[
https://issues.apache.org/jira/browse/HDFS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458448#comment-13458448
]
Todd Lipcon commented on HDFS-3957:
-----------------------------------
- Instead of implementing your own ThreadFactory, you can use
ThreadFactoryBuilder from Guava for the same effect
- What's the point of the MetricsExecutor interface? Seems like overkill here,
especially since no one else is using it and no one ever calls stop(). I'd
think we could get away with just having a static ExecutorService inside
MutableQuantiles, and if we end up with a proliferation of other executors in
the code base for metrics we can centralize as necessary.
> Change MutableQuantiles to use a shared thread for rolling over metrics
> -----------------------------------------------------------------------
>
> Key: HDFS-3957
> URL: https://issues.apache.org/jira/browse/HDFS-3957
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.3-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Minor
> Attachments: hdfs-3957-1.patch
>
>
> Each MutableQuantiles currently creates its own thread to rollover the
> histogram every interval. It'd be better to do this with a single, shared
> thread or executor, and do it with a ThreadFactory that names it properly.
> Similar changes were made when porting MutableQuantiles to HBase in
> HBASE-6409, so this would also help keep them in sync.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
