[ 
https://issues.apache.org/jira/browse/HDFS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458938#comment-13458938
 ] 

Eli Collins commented on HDFS-3932:
-----------------------------------

- determineHttpAddress would be better named something like 
getNameNodeRpcAddressForHttpServer since we're getting the NN RPC address not 
the HTTP address (which is a different port)
- Did you consider resolving the hostname to an IP rather than passing the 
hostname verbatim, eg use getHostAddress instead of getHostName or resolve the 
hostname returned here if getHostAddress is not equivalent?  If we pass the 
hostname do we need to URL encode it?
- In the javadoc would replace of "the name.node.address to use" with something 
more descriptive, eg 
{noformat}
Determine the NameNode RPC address to pass in the name.node.address Http server 
attribute
for use by the Web UI and servlets. If the NameNode has bound the RPC server to 
the
wildcard then we use the hostname (which we assume has an active RPC server).
{noformat}
- The test should also check for the loopback IP for sanity  
- Test the broken web UI links and hftp (eg using distcp) on a pseudo cluster 
that binds the rpc addr to the wildcard?
 
                
> NameNode Web UI broken if the rpc-address is set to the wildcard   
> -------------------------------------------------------------------
>
>                 Key: HDFS-3932
>                 URL: https://issues.apache.org/jira/browse/HDFS-3932
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: HDFS-3932.001.patch, HDFS-3932.002.patch, 
> HDFS-3932.003.patch
>
>
> If {{dfs.namenode.rpc-address}} is set to the wildcard some of links in the 
> dfsnodelist.jsp and browseDirectory.jsp pages are broken because the nnaddr 
> field is passed verbatim (eg nnaddr=0.0.0.0:8021).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to