[ 
https://issues.apache.org/jira/browse/HDFS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459263#comment-13459263
 ] 

Eli Collins commented on HDFS-3932:
-----------------------------------

- Rather than loop through IPs I think it would be better to use 
DNS#getDefaultIP("default"). This may return the loopback IP eg on a developer 
local install but that's OK because that would be a valid IP to use on a 
developer local install anway. IIUC on real clusters we require this not be the 
loopback. We should add a wrapper so you can just call DNS#getDefaultIP().
- The javadoc doesn't match the implementation (it says use the hostname)
- The test should check all the cases the code checks (multicast, link-local 
and loopback here, but see above about not checking loopback)
                
> NameNode Web UI broken if the rpc-address is set to the wildcard   
> -------------------------------------------------------------------
>
>                 Key: HDFS-3932
>                 URL: https://issues.apache.org/jira/browse/HDFS-3932
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: HDFS-3932.001.patch, HDFS-3932.002.patch, 
> HDFS-3932.003.patch, HDFS-3932.005.patch
>
>
> If {{dfs.namenode.rpc-address}} is set to the wildcard some of links in the 
> dfsnodelist.jsp and browseDirectory.jsp pages are broken because the nnaddr 
> field is passed verbatim (eg nnaddr=0.0.0.0:8021).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to