[
https://issues.apache.org/jira/browse/HDFS-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495667#comment-13495667
]
Daryn Sharp commented on HDFS-4181:
-----------------------------------
It seems odd to check if debugging is enabled to issue an alternate error. I'd
suggest changing:
{code}
if (LOG.isDebugEnabled()) {
LOG.error(src + " not found in lease.paths (=" + lease.paths + ")");
} else {
LOG.error(src + " not found in lease.paths.");
}
{code} to {code}
LOG.error(src + " not found in lease.paths");
if (LOG.isDebugEnabled()) {
LOG.debug("lease.paths = (" + lease.paths + ")");
}
{code}
Otherwise it looks good if the pre-commit passes.
> LeaseManager tries to double remove and prints extra messages
> -------------------------------------------------------------
>
> Key: HDFS-4181
> URL: https://issues.apache.org/jira/browse/HDFS-4181
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.4, 2.0.2-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Critical
> Attachments: hdfs-4181-branch-0.23.patch, hdfs-4181-trunk.patch
>
>
> When checkLeases() runs, internalReleaseLease() is called on the expired
> ones. When it returns true, the lease is already removed, yet it is tried
> again in checkLease(). This causes unnecessary ERROR messages to be logged.
> The line doing {{removing.add(p)}} should be removed.
> The internalReleaseLease() method logs a detailed message per call, so the
> extra INFO log message from checkLease() is redundant.
> The error message from removeLease() can be very big and needs to be cut
> down. When the namenode itself is holding a lot of leases for block recovery,
> hitting this error is very expensive. In one instance, slow block recovery
> caused the namenode to hold more than 42K leases. The one log line in this
> case was over 4 MB. The dump of data structure should be only enabled in
> debug mode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
