[
https://issues.apache.org/jira/browse/HDFS-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495735#comment-13495735
]
Hadoop QA commented on HDFS-4181:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12553193/hdfs-4181-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3488//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3488//console
This message is automatically generated.
> LeaseManager tries to double remove and prints extra messages
> -------------------------------------------------------------
>
> Key: HDFS-4181
> URL: https://issues.apache.org/jira/browse/HDFS-4181
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.4, 2.0.2-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Critical
> Attachments: hdfs-4181-branch-0.23.patch,
> hdfs-4181-branch-0.23.patch, hdfs-4181-trunk.patch, hdfs-4181-trunk.patch
>
>
> When checkLeases() runs, internalReleaseLease() is called on the expired
> ones. When it returns true, the lease is already removed, yet it is tried
> again in checkLease(). This causes unnecessary ERROR messages to be logged.
> The line doing {{removing.add(p)}} should be removed.
> The internalReleaseLease() method logs a detailed message per call, so the
> extra INFO log message from checkLease() is redundant.
> The error message from removeLease() can be very big and needs to be cut
> down. When the namenode itself is holding a lot of leases for block recovery,
> hitting this error is very expensive. In one instance, slow block recovery
> caused the namenode to hold more than 42K leases. The one log line in this
> case was over 4 MB. The dump of data structure should be only enabled in
> debug mode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
