[ 
https://issues.apache.org/jira/browse/HDFS-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498497#comment-13498497
 ] 

Colin Patrick McCabe commented on HDFS-4196:
--------------------------------------------

Hi Jing,

This looks good to me.  One question: can you elaborate on this TODO?

{code}
// TODO: check if the new name is valid. May also need this for
// creationSnapshot
{code}

Also, if there a JIRA associated with the TODO, it might be helpful to add a 
reference to it in the comment.
                
> Support renaming of snapshots
> -----------------------------
>
>                 Key: HDFS-4196
>                 URL: https://issues.apache.org/jira/browse/HDFS-4196
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, name-node
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4196.001.patch, HDFS-4196.002.patch
>
>
> Add the functionality of renaming an existing snapshot with a given new name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to