[ 
https://issues.apache.org/jira/browse/HDFS-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499217#comment-13499217
 ] 

Jing Zhao commented on HDFS-4196:
---------------------------------

Aaron, thanks for the comments. For the synchronization from 
SnapshotManager#createSnapshot, I think we may remove the synchronization in 
the SnapshotManager, but explicitly acquiring the write lock of FSDirectory 
seems still necessary to me. Otherwise it is possible that some operation tries 
to change FSDir between individual FSDir read/write calls within 
SnapshotManager#createSnapshot (although FSDir#getINode etc. needs to acquire 
the read or write lock of FSDir). I'm not sure if FSNS locking can prevent this 
scenario?
                
> Support renaming of snapshots
> -----------------------------
>
>                 Key: HDFS-4196
>                 URL: https://issues.apache.org/jira/browse/HDFS-4196
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, name-node
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4196.001.patch, HDFS-4196.002.patch, 
> HDFS-4196.003.patch
>
>
> Add the functionality of renaming an existing snapshot with a given new name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to