[
https://issues.apache.org/jira/browse/HDFS-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated HDFS-4209:
-----------------------------------------
Description:
- FSDirectory.addToParent(..) is only used by image loading so that
synchronization, modification time update and space count update are not needed.
- There are multiple places checking whether an inode is file by checking
!isDirectory() && !isSymlink(). Let's add isFile() to INode.
- In the addNode/addChild/addChildNoQuotaCheck methods, returning the same
INode back is not useful. It is better to simply return a boolean to indicate
whether the inode is added. Also, the value of childDiskspace parameter is
always UNKNOWN_DISK_SPACE.
was:
- FSDirectory.addToParent(..) is only used by image loading so that
synchronization, modification time update and space count update are not needed.
- There are multiple places checking whether an inode is file by checking
!isDirectory() && !isSymlink(). Let's add isFile() to INode.
- The addNode/addChild/addChildNoQuotaCheck methods returning the same INode
back is not useful. It is better to simply return a boolean to indicate
whether the inode is added. Also, the childDiskspace parameter is always
unknown.
> Clean up FSDirectory and INode
> ------------------------------
>
> Key: HDFS-4209
> URL: https://issues.apache.org/jira/browse/HDFS-4209
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h4209_20121118.patch
>
>
> - FSDirectory.addToParent(..) is only used by image loading so that
> synchronization, modification time update and space count update are not
> needed.
> - There are multiple places checking whether an inode is file by checking
> !isDirectory() && !isSymlink(). Let's add isFile() to INode.
> - In the addNode/addChild/addChildNoQuotaCheck methods, returning the same
> INode back is not useful. It is better to simply return a boolean to
> indicate whether the inode is added. Also, the value of childDiskspace
> parameter is always UNKNOWN_DISK_SPACE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
