[
https://issues.apache.org/jira/browse/HDFS-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500009#comment-13500009
]
Hadoop QA commented on HDFS-4209:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12554106/h4209_20121118b.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.cli.TestHDFSCLI
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3537//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3537//console
This message is automatically generated.
> Clean up FSDirectory and INode
> ------------------------------
>
> Key: HDFS-4209
> URL: https://issues.apache.org/jira/browse/HDFS-4209
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h4209_20121118b.patch, h4209_20121118.patch
>
>
> - FSDirectory.addToParent(..) is only used by image loading so that
> synchronization, modification time update and space count update are not
> needed.
> - There are multiple places checking whether an inode is file by checking
> !isDirectory() && !isSymlink(). Let's add isFile() to INode.
> - In the addNode/addChild/addChildNoQuotaCheck methods, returning the same
> INode back is not useful. It is better to simply return a boolean to
> indicate whether the inode is added. Also, the value of childDiskspace
> parameter is always UNKNOWN_DISK_SPACE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
