[ 
https://issues.apache.org/jira/browse/HDFS-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502252#comment-13502252
 ] 

Andrew Wang commented on HDFS-4199:
-----------------------------------

Thanks for pulling me in Robert. I think you're right. Equality of the id's is 
meaningless if they aren't valid. Right now we assume that users of 
DFS#getFileBlockStorageLocations() know to check isValid() first, but better 
would be to fix HdfsVolumeId to make all invalid ids equal, and not equal to 
any valid ids.
                
> Provide test for HdfsVolumeId
> -----------------------------
>
>                 Key: HDFS-4199
>                 URL: https://issues.apache.org/jira/browse/HDFS-4199
>             Project: Hadoop HDFS
>          Issue Type: Test
>    Affects Versions: 2.0.2-alpha
>            Reporter: Ivan A. Veselovsky
>            Assignee: Ivan A. Veselovsky
>            Priority: Minor
>         Attachments: HADOOP-9053.patch, HDFS-4199--b.patch, HDFS-4199.patch
>
>
> Provide test for HdfsVolumeId to improve the code coverage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to