[
https://issues.apache.org/jira/browse/HDFS-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507823#comment-13507823
]
Andrew Wang commented on HDFS-4199:
-----------------------------------
Ivan, I think you're right on the null byte[]. Semantically, valid
HdfsVolumeIds shouldn't have a null byte[]. Originally I did it for invalid
Id's just to reinforce the invalidity. Feel free to tack on that change.
Otherwise LGTM, thanks for working on the patch!
> Provide test for HdfsVolumeId
> -----------------------------
>
> Key: HDFS-4199
> URL: https://issues.apache.org/jira/browse/HDFS-4199
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 3.0.0, 2.0.3-alpha
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Attachments: HADOOP-9053.patch, HDFS-4199--b.patch,
> HDFS-4199--c.patch, HDFS-4199--d.patch, HDFS-4199.patch
>
>
> Provide test for HdfsVolumeId to improve the code coverage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
