[
https://issues.apache.org/jira/browse/HDFS-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505164#comment-13505164
]
Aaron T. Myers commented on HDFS-4214:
--------------------------------------
bq. even though this is just a debug log, the information printed will be used
for taking next steps on how to fix the editlog, right? If so, should we add a
unit test anyway?
What sort of test do you have in mind? One that checks that something is
actually written to stderr? Or a test that EditLogInputStream#getPosition
actually returns what's expected? In general I'm all for more tests, but this
seems like a spot where it's annoying to write one and it won't actually test
much.
> OfflineEditsViewer should print out the offset at which it encountered an
> error
> -------------------------------------------------------------------------------
>
> Key: HDFS-4214
> URL: https://issues.apache.org/jira/browse/HDFS-4214
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Affects Versions: 2.0.3-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Trivial
> Fix For: 2.0.3-alpha
>
> Attachments: HDFS-4214.001.patch
>
>
> OfflineEditsViewer should print out the offset at which it encountered an
> error. This helps developers or users debug problems with loading malformed
> logs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
