[ 
https://issues.apache.org/jira/browse/HDFS-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505826#comment-13505826
 ] 

Suresh Srinivas commented on HDFS-4214:
---------------------------------------

bq. I doubt that EditLogInputStream#getPosition could break without a huge 
number of edit log unit tests breaking...
I have looked at recovery mode tests, which I think is the most relevant to my 
previous comment. But if those are based on the correctness of getPosition(), 
then this change can go without tests.
                
> OfflineEditsViewer should print out the offset at which it encountered an 
> error
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-4214
>                 URL: https://issues.apache.org/jira/browse/HDFS-4214
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-4214.001.patch
>
>
> OfflineEditsViewer should print out the offset at which it encountered an 
> error.  This helps developers or users debug problems with loading malformed 
> logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to