[ 
https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507844#comment-13507844
 ] 

Jing Zhao commented on HDFS-4248:
---------------------------------

The patch looks very good. +1 for the patch. The only very minor issue is that 
for the new testcase testLeaseAfterRename() we can remove the commented 
"out.hsync();" line.
                
> Renames may cause dangling leases
> ---------------------------------
>
>                 Key: HDFS-4248
>                 URL: https://issues.apache.org/jira/browse/HDFS-4248
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Blocker
>         Attachments: HDFS-4248.branch-0.23.patch, HDFS-4248.patch
>
>
> Renames of directories may incorrectly re-write the paths in leases under the 
> tree being moved.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to