[
https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507895#comment-13507895
]
Jing Zhao commented on HDFS-4248:
---------------------------------
I tried to run Daryn's new testcase without his fix, and could get a similar
result with Nicholas, i.e., for new rename to existing dir with OVERWRITE opt,
the old lease is removed instead of renamed. (This is because in
FSDirectory#unprotectedRenameTo(String, String, long, Options.Rename...),
FSNamesystem#removePathAndBlocks is called in the end which removes leases with
prefix path src. Daryn's patch can fix the bug since the unprotectedChangeLease
call is now moved before calling FSNamesystem#removePathAndBlocks.)
> Renames may cause dangling leases
> ---------------------------------
>
> Key: HDFS-4248
> URL: https://issues.apache.org/jira/browse/HDFS-4248
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Blocker
> Attachments: h4248_20121130_test_rename.patch,
> HDFS-4248.branch-0.23.patch, HDFS-4248.patch
>
>
> Renames of directories may incorrectly re-write the paths in leases under the
> tree being moved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira