[
https://issues.apache.org/jira/browse/HDFS-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509454#comment-13509454
]
Aaron T. Myers commented on HDFS-4199:
--------------------------------------
The latest patch looks pretty good to me. Two small nits, +1 once these are
addressed:
# Generally in the Hadoop codebase we put the "@Test" annotation right above
the method declaration, below the method comment:
{code}
+ @Test
+ /*
+ * test #toString() for typical VolumeId equality classes
+ */
{code}
# In the class declaration of INVALID_VOLUME_ID, I recommend putting a blank
line between the methods being declared there.
Thanks a lot for improving the test coverage in this area of the code, Ivan,
and thanks a lot to Andrew for your reviews of these patches.
> Provide test for HdfsVolumeId
> -----------------------------
>
> Key: HDFS-4199
> URL: https://issues.apache.org/jira/browse/HDFS-4199
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 3.0.0, 2.0.3-alpha
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Attachments: HADOOP-9053.patch, HDFS-4199--b.patch,
> HDFS-4199--c.patch, HDFS-4199--d.patch, HDFS-4199--e.patch, HDFS-4199.patch
>
>
> Provide test for HdfsVolumeId to improve the code coverage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
