[
https://issues.apache.org/jira/browse/HDFS-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542270#comment-13542270
]
Brandon Li commented on HDFS-4346:
----------------------------------
The patch looks good.
Just one minor comment: looks like we can get the last reserved value by either
calling getLastReservedValue() or using "public static" variable
LAST_RESERVED_STAMP and LAST_RESERVED_ID directly. Any reason we keep both ways
available?
> Refactor INodeId and GenerationStamp
> ------------------------------------
>
> Key: HDFS-4346
> URL: https://issues.apache.org/jira/browse/HDFS-4346
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h4346_20121231.patch, h4346_20130101.patch
>
>
> The INodeId and GenerationStamp classes are very similar. It is better to
> refactor them for code sharing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
