[ 
https://issues.apache.org/jira/browse/HDFS-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543210#comment-13543210
 ] 

Aaron T. Myers commented on HDFS-4346:
--------------------------------------

Also, Nicholas, I notice that the entry in CHANGES.txt corresponding to this 
commit does not match the description of this JIRA:
{noformat}
HDFS-4346. Add SequentialNumber as a base class for INodeId and
GenerationStamp.  (szetszwo)
{noformat}

Was this intentional? If not, I think we should change either the entry in 
CHANGES.txt or the title of this JIRA. Either way is fine by me.
                
> Refactor INodeId and GenerationStamp
> ------------------------------------
>
>                 Key: HDFS-4346
>                 URL: https://issues.apache.org/jira/browse/HDFS-4346
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: h4346_20121231.patch, h4346_20130101.patch, 
> h4346_20130102.patch
>
>
> The INodeId and GenerationStamp classes are very similar.  It is better to 
> refactor them for code sharing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to