[ 
https://issues.apache.org/jira/browse/HDFS-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543496#comment-13543496
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4346:
----------------------------------------------

> I think SequentialNumber.java was accidentally excluded from the commit.

You are right.  I forgot to commit the new file.

Aaron, thanks for committing the file!

> Also, Nicholas, I notice that the entry in CHANGES.txt corresponding to this 
> commit does not match the description of this JIRA ...

I think you may mean summary instead of description.

> Was this intentional? ...

Yes, the entry in CHANGES.txt is not necessarily the same as the summary since 
the summary may only contain a general idea but the entry in CHANGES.txt should 
be more specific.
                
> Refactor INodeId and GenerationStamp
> ------------------------------------
>
>                 Key: HDFS-4346
>                 URL: https://issues.apache.org/jira/browse/HDFS-4346
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: h4346_20121231.patch, h4346_20130101.patch, 
> h4346_20130102.patch
>
>
> The INodeId and GenerationStamp classes are very similar.  It is better to 
> refactor them for code sharing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to