[ 
https://issues.apache.org/jira/browse/HDFS-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548857#comment-13548857
 ] 

Aaron T. Myers commented on HDFS-4367:
--------------------------------------

+1, the patch looks good to me.

I don't think this should be considered an incompatible change since old 
clients will in fact never request a DataEncryptionKey when data encryption 
isn't enabled. i.e. a client will never request an encryption key from the NN 
in a scenario where it's possible for the NN to return a null response.
                
> GetDataEncryptionKeyResponseProto  does not handle null response
> ----------------------------------------------------------------
>
>                 Key: HDFS-4367
>                 URL: https://issues.apache.org/jira/browse/HDFS-4367
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.2-alpha
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Blocker
>         Attachments: HDFS-4367.patch
>
>
> GetDataEncryptionKeyResponseProto member dataEncryptionKey should be optional 
> to handle null response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to