[ 
https://issues.apache.org/jira/browse/HDFS-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549050#comment-13549050
 ] 

Aaron T. Myers commented on HDFS-4367:
--------------------------------------

Hey Suresh, if I understand you correctly, you're saying that, assuming 
dfs.block.access.token.enable is set to false and dfs.encrypt.data.transfer is 
set to true:

# Before this change we'd end up with a null pointer exception on the server, 
since you can't set a "required" field to null.
# After this change we'd end up with a null pointer exception on the client, 
since null would now be returned but this isn't handled correctly by 2.0.2 
client code.

If my understanding of your point is correct, then I would counter that having 
"dfs.block.access.token.enable" set to false and "dfs.encrypt.data.transfer" 
set to true is not a legitimate configuration. Clearly no existing (2.0.2) 
deployment could be running with such a configuration since HDFS reads/writes 
would not work. Given that, all existing deployments which are using this 
feature must have dfs.block.access.token.enable set to true if they have 
dfs.encrypt.data.transfer set to true. This would mean that, even after this 
change, all 2.0.2 clients could still communicate with 2.0.3 servers, and vice 
versa. Hence, this change should not be considered incompatible.
                
> GetDataEncryptionKeyResponseProto  does not handle null response
> ----------------------------------------------------------------
>
>                 Key: HDFS-4367
>                 URL: https://issues.apache.org/jira/browse/HDFS-4367
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.2-alpha
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Blocker
>         Attachments: HDFS-4367.patch
>
>
> GetDataEncryptionKeyResponseProto member dataEncryptionKey should be optional 
> to handle null response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to