[
https://issues.apache.org/jira/browse/HDFS-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556511#comment-13556511
]
Todd Lipcon commented on HDFS-4416:
-----------------------------------
I think this might inadvertently add a bug -- now that we have a default
(empty) for the socket path, the various places in the code where we check
against 'null' won't work anymore, since it will be the empty string.
I think we need to do something like:
{code}
public static String getDomainSocketPath(Configuration conf) {
String s = conf.getTrimmed(DFSConfigKeys.DFS_DOMAIN_SOCKET_PATH_KEY);
return s.isEmpty() ? null : s;
}
{code}
and use that wherever we fetch the value from the config.
> change dfs.datanode.domain.socket.path to dfs.domain.socket.path
> ----------------------------------------------------------------
>
> Key: HDFS-4416
> URL: https://issues.apache.org/jira/browse/HDFS-4416
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, hdfs-client, performance
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-4416.001.patch, HDFS-4416.002.patch
>
>
> {{dfs.datanode.domain.socket.path}} is used by both clients and the DataNode,
> so it might be best to avoid putting 'datanode' in the name. Most of the
> configuration keys that have 'datanode' in the name apply only to the DN.
> Also, should change __PORT__ to _PORT to be consistent with _HOST, etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
