[ 
https://issues.apache.org/jira/browse/HDFS-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556701#comment-13556701
 ] 

Todd Lipcon commented on HDFS-4416:
-----------------------------------

- can you change the conf.get() calls to conf.getTrimmed()? We've often seem 
issues where people end up with extra whitespace in their configs, and end up 
with files like "/home/hdfs/ /foo/bar" (literal whitespace dirs).

Otherwise lgtm.

                
> change dfs.datanode.domain.socket.path to dfs.domain.socket.path
> ----------------------------------------------------------------
>
>                 Key: HDFS-4416
>                 URL: https://issues.apache.org/jira/browse/HDFS-4416
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, hdfs-client, performance
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-4416.001.patch, HDFS-4416.002.patch, 
> HDFS-4416.003.patch
>
>
> {{dfs.datanode.domain.socket.path}} is used by both clients and the DataNode, 
> so it might be best to avoid putting 'datanode' in the name.  Most of the 
> configuration keys that have 'datanode' in the name apply only to the DN.
> Also, should change __PORT__ to _PORT to be consistent with _HOST, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to