[
https://issues.apache.org/jira/browse/HDFS-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559393#comment-13559393
]
Suresh Srinivas commented on HDFS-4126:
---------------------------------------
# DFSUtil#byte2String - add javadoc
# FSImageFormat.java
#* In the javadoc, SnapshotID under FSImage should be snapshotCounter or
nextSnapshotID. Should we change the SnapshotManager#snapshotID to
SnapshotManager#snapshotCounter?
#* As per our conversation, the INodeFile FSImage ContainsBlock will change
when we do the file level diff and simplify the FSImage. Hence I am okay with
the current code.
#* ComputedFileSize in javadoc could be called snapshotFileSize. The
corresponding variable name could also be updated accordingly.
#* Snapshot in javadoc is missing snapshot name?
#* javadoc could consoldiate snapshot supported fields together
n
#* loadRoot should return void and numFiles-- should be used. Returning 1
always just for decrement purpose does not seem intutive.
#* Snapshot related methods should be moved to an inner class or separate
class. This can be done in a separate jira.
# FileWithSnapshot impelementation #insertBefore and #removeSelf code seems to
be repeated in implementation?
# Add a summary of test information to the javadoc of test methods
# For commented tests can please add TODO and a brief description
> Add reading/writing snapshot information to FSImage
> ---------------------------------------------------
>
> Key: HDFS-4126
> URL: https://issues.apache.org/jira/browse/HDFS-4126
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: Snapshot (HDFS-2802)
> Reporter: Suresh Srinivas
> Assignee: Jing Zhao
> Attachments: HDFS-4126.001.patch, HDFS-4126.002.patch,
> HDFS-4126.002.patch
>
>
> After the changes proposed in HDFS-4125 is completed, reading and writing
> snapshot related information from FSImage can be implemented. This jira
> tracks changes required for:
> # Loading snapshot information from FSImage
> # Loading snapshot related operations from editlog
> # Writing snapshot information in FSImage
> # Unit tests related to this functionality
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
