[ 
https://issues.apache.org/jira/browse/HDFS-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560077#comment-13560077
 ] 

Jing Zhao commented on HDFS-4126:
---------------------------------

bq. Snapshot in javadoc is missing snapshot name?
The snapshot name is actually stored as the local name of the Snapshot#root. 
Added explanation in the javadoc.

bq. Snapshot related methods should be moved to an inner class or separate 
class. This can be done in a separate jira.
Created a new class SnapshotFSImageFormat in the snapshot package, and move 
snapshot-related fsimage read/write methods to the new class as static members.
                
> Add reading/writing snapshot information to FSImage
> ---------------------------------------------------
>
>                 Key: HDFS-4126
>                 URL: https://issues.apache.org/jira/browse/HDFS-4126
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: Snapshot (HDFS-2802)
>            Reporter: Suresh Srinivas
>            Assignee: Jing Zhao
>         Attachments: HDFS-4126.001.patch, HDFS-4126.002.patch, 
> HDFS-4126.002.patch, HDFS-4126.003.patch
>
>
> After the changes proposed in HDFS-4125 is completed, reading and writing 
> snapshot related information from FSImage can be implemented. This jira 
> tracks changes required for:
> # Loading snapshot information from FSImage
> # Loading snapshot related operations from editlog
> # Writing snapshot information in FSImage
> # Unit tests related to this functionality

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to