[
https://issues.apache.org/jira/browse/HDFS-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566643#comment-13566643
]
Hadoop QA commented on HDFS-4445:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12567159/HDFS-4445.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3909//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3909//console
This message is automatically generated.
> All BKJM ledgers are not checked while tailing, So failover will fail.
> ----------------------------------------------------------------------
>
> Key: HDFS-4445
> URL: https://issues.apache.org/jira/browse/HDFS-4445
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.0.3-alpha
> Reporter: Vinay
> Assignee: Vinay
> Priority: Blocker
> Attachments: HDFS-4445.patch
>
>
> After the fix of HDFS-4130, all editlog nodes are not iterated if first edit
> are below fromTxId
> Problem part is below code inside
> BookKeeperJournalManager#selectInputStreams(..)
> {code} if (fromTxId >= l.getFirstTxId() && fromTxId <= lastTxId) {
> LedgerHandle h;
> if (l.isInProgress()) { // we don't want to fence the current
> journal
> h = bkc.openLedgerNoRecovery(l.getLedgerId(), digestType,
> digestpw.getBytes());
> } else {
> h = bkc
> .openLedger(l.getLedgerId(), digestType, digestpw.getBytes());
> }
> elis = new BookKeeperEditLogInputStream(h, l);
> elis.skipTo(fromTxId);
> } else {
> return;
> }{code}
> The else block should have continue statement instead of return.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
