[
https://issues.apache.org/jira/browse/HDFS-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569825#comment-13569825
]
Hudson commented on HDFS-4445:
------------------------------
Integrated in Hadoop-trunk-Commit #3316 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/3316/])
HDFS-4445. All BKJM ledgers are not checked while tailing, So failover will
fail. Contributed Vinay. (Revision 1441935)
Result = SUCCESS
umamahesh :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441935
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperAsHASharedDir.java
> All BKJM ledgers are not checked while tailing, So failover will fail.
> ----------------------------------------------------------------------
>
> Key: HDFS-4445
> URL: https://issues.apache.org/jira/browse/HDFS-4445
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.0.3-alpha
> Reporter: Vinay
> Assignee: Vinay
> Priority: Blocker
> Attachments: HDFS-4445.patch
>
>
> After the fix of HDFS-4130, all editlog nodes are not iterated if first edit
> are below fromTxId
> Problem part is below code inside
> BookKeeperJournalManager#selectInputStreams(..)
> {code} if (fromTxId >= l.getFirstTxId() && fromTxId <= lastTxId) {
> LedgerHandle h;
> if (l.isInProgress()) { // we don't want to fence the current
> journal
> h = bkc.openLedgerNoRecovery(l.getLedgerId(), digestType,
> digestpw.getBytes());
> } else {
> h = bkc
> .openLedger(l.getLedgerId(), digestType, digestpw.getBytes());
> }
> elis = new BookKeeperEditLogInputStream(h, l);
> elis.skipTo(fromTxId);
> } else {
> return;
> }{code}
> The else block should have continue statement instead of return.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
