[ 
https://issues.apache.org/jira/browse/HDFS-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566931#comment-13566931
 ] 

Alejandro Abdelnur commented on HDFS-4456:
------------------------------------------

Plamen, thanks for jumping on this one. Patch looks goods, a few of minor 
comments/questions:

* HttpFSFileSystem.java: where adding Operation.RENAME.getMethod() it should be 
Operation.CONCAT.getMethod()

* We should add a concat test to BaseTestHttpFSWith.java, this will test it 
with do tests with different combinations of filesystem clients/backends (in 
its 3 test subclasses)

* It would be good to mention in the docs if the file resulting on the 
concatenation should not exist.

* We should mention in the docs that this new REST API call is avail since 
version ##### of Hadoop.

* Why do we require the response to have content length = 0 in addition to the 
HTTP_OK status? It seems superflous.






                
> Add concat to WebHDFS REST API
> ------------------------------
>
>                 Key: HDFS-4456
>                 URL: https://issues.apache.org/jira/browse/HDFS-4456
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: webhdfs
>    Affects Versions: 3.0.0, 2.0.3-alpha
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Plamen Jeliazkov
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HDFS-3598.trunk.docAndHttpFS.patch, 
> HDFS-4456.trunk.docAndHttpFS.patch
>
>
> HDFS-3598 adds the concat feature to WebHDFS.  The REST API should be updated 
> accordingly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to