[
https://issues.apache.org/jira/browse/HDFS-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570825#comment-13570825
]
Suresh Srinivas commented on HDFS-4340:
---------------------------------------
Early comments:
# hdfs.proto
#* Please use fileId instead of file_id (as with the other fields in the .proto
file)
#* What is the reason for adding default value to the field?
# ClientNamenodeProtocol.proto
#* Again, what is the reason for adding default value to the field?
# For optional params, please use hasField() convention to check if the field
is set.
> Update addBlock() to inculde inode id as additional argument
> ------------------------------------------------------------
>
> Key: HDFS-4340
> URL: https://issues.apache.org/jira/browse/HDFS-4340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, namenode
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch,
> HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch,
> HDFS-4340.patch, HDFS-4340.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
