[
https://issues.apache.org/jira/browse/HDFS-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571634#comment-13571634
]
Suresh Srinivas commented on HDFS-4340:
---------------------------------------
Additional comments:
# Please mention in ClientProtocol#createFile, the returned HdfsFileStatus
could be null, if the server does not return file status.
# Please mention in FSNamesystem#startFile() - returned HdfsFileStatus is
always non null. Why are we again parsing the path in this method to get the
file info? Can we avoid this by having an implementation that returns
LocatedBlock for append and FileStatus for startFile()?
# FSNamesystem#getAdditionalBlock() does not seem to be using fileId?
# Please update the public APIs where new INodeIdMismatchedException can be
thrown. BTW INodeIdMismatchedException should be subclass of
FileNotFoundException?
# TestDFSClientRetries - unused import UnresolveLinkException. Cast to long
unnecessary for 1010 at two places.
# TestLeast - unused import anyCollection, FileStatus. Cast to long unnecessary
for 1010 at two places. Why SuppressWarning?
# TestINodeFile - unused import DFSClient. Not sure why you need nnrpc and
cannot use fs?
> Update addBlock() to inculde inode id as additional argument
> ------------------------------------------------------------
>
> Key: HDFS-4340
> URL: https://issues.apache.org/jira/browse/HDFS-4340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, namenode
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch,
> HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch,
> HDFS-4340.patch, HDFS-4340.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
