[
https://issues.apache.org/jira/browse/HDFS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632123#comment-13632123
]
Hadoop QA commented on HDFS-4661:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12577653/HDFS-4661.004.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4253//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4253//console
This message is automatically generated.
> code style fixes suggested by Nicholas
> --------------------------------------
>
> Key: HDFS-4661
> URL: https://issues.apache.org/jira/browse/HDFS-4661
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, hdfs-client, performance
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-4661.001.patch, HDFS-4661.002.patch,
> HDFS-4661.003.patch, HDFS-4661.004.patch
>
>
> * The log statement in DataXceiver
> "BlockSender.ClientTraceLog.info("REQUEST_SHORT_CIRCUIT_FDS"...)" could be
> cleaned up somewhat.
> * use {{FsDatasetSpi#getBlockInputStream}} and
> {{FsDatasetSpi#getMetaDataInputStream}} rather than adding
> {{FsDatasetSpi#getShortCircuitFdsForRead}}
> * {{FileInputStreamCache.Key.equals}}: use short-circuit boolean AND
> * In FileInputStreamCache.CacheCleaner, the code "iter =
> map.entries().iterator()" can be removed with the same result since the
> (previous) first element must be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
