[
https://issues.apache.org/jira/browse/HDFS-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687138#comment-13687138
]
Jing Zhao commented on HDFS-4908:
---------------------------------
I replaced the editStored file with the new one, and TestOfflineEditsViewer
passed in my local machine.
The patch looks good to me. Only some minor issues:
1. For INodeAttributes.Copy, INodeFileAttributes.Copy,
INodeDirectoryAttributes.Copy, and INodeDirectoryAttributes.CopyWithQuota:
The class name Copy here may seem too generic, maybe we can call them
SnapshotCopy?
2. LayoutVersion.java:
{code}
OPTIMIZE_SNAPSHOT_INODES(-45, -43,
"Reduce snapshot inode memory footprint.", false);
{code}
We can remove the "." in the description.
> Reduce snapshot inode memory usage
> ----------------------------------
>
> Key: HDFS-4908
> URL: https://issues.apache.org/jira/browse/HDFS-4908
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode, snapshots
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.1.0-beta
>
> Attachments: editsStored, h4908_20130617b.patch,
> h4908_20130617c.patch, h4908_20130617.patch
>
>
> Snapshots currently use INodeFile and INodeDirectory for storing previous
> file/dir states as snapshot inodes. However, INodeFile and INodeDirectory
> have some fields not used by snapshot inodes such as parent reference, inode
> id, block/children reference. The memory footprint could be reduced by
> having some specific classes for snapshot inodes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
