[
https://issues.apache.org/jira/browse/HDFS-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687216#comment-13687216
]
Jing Zhao commented on HDFS-4908:
---------------------------------
3. FSImageFormat#loadINodeDirectoryAttributes
since this method is only called by loadSnapshotInodeInDirectoryDiff, do we
still need the layout version check in
{code}
if (LayoutVersion.supports(Feature.DISKSPACE_QUOTA, layoutVersion)) {
dsQuota = in.readLong();
}
{code}
Similary for loadINodeFileAttributes, do we need to check for the accessTime?
> Reduce snapshot inode memory usage
> ----------------------------------
>
> Key: HDFS-4908
> URL: https://issues.apache.org/jira/browse/HDFS-4908
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode, snapshots
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.1.0-beta
>
> Attachments: editsStored, h4908_20130617b.patch,
> h4908_20130617c.patch, h4908_20130617.patch
>
>
> Snapshots currently use INodeFile and INodeDirectory for storing previous
> file/dir states as snapshot inodes. However, INodeFile and INodeDirectory
> have some fields not used by snapshot inodes such as parent reference, inode
> id, block/children reference. The memory footprint could be reduced by
> having some specific classes for snapshot inodes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
