[ 
https://issues.apache.org/jira/browse/HDFS-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687673#comment-13687673
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4918:
----------------------------------------------

> I guess the question is more about backward-compatibility and also if the 
> feature (dfs.permissions.enabled) is actually expected to behave as its 
> documented. We can turn on perms if required, but the issue still remains.

Just checked the branch-1 code, it is the same as trunk: 
setPermission(..)/setOwner(..) does not check isPermissionsEnabled; see 
http://svn.apache.org/viewvc/hadoop/common/branches/branch-1/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java?view=annotate

That part of HDFS code has not been changed for a long time.  So there is no 
compatibility issue in HDFS.  You may want to file a MR jira.

Also checked the documentation, it says that the current behavior is correct, 
i.e. setPermission(..)/setOwner(..) should always check permission.  Below is 
quoted from 
http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsPermissionsGuide.html#Configuration_Parameters
{quote}
... Regardless of whether permissions are on or off, chmod, chgrp and chown 
always check permissions. These functions are only useful in the permissions 
context, and so there is no backwards compatibility issue. Furthermore, this 
allows administrators to reliably set owners and permissions in advance of 
turning on regular permissions checking.
{quote}

                
> HDFS permission check is incorrect
> ----------------------------------
>
>                 Key: HDFS-4918
>                 URL: https://issues.apache.org/jira/browse/HDFS-4918
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client, namenode
>    Affects Versions: 2.0.0-alpha
>            Reporter: Fengdong Yu
>
> HDFS permisson check is incorrect, even if dfs.permissions is set false. it 
> does look like this was caused by snap shot.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to