[ 
https://issues.apache.org/jira/browse/HDFS-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694413#comment-13694413
 ] 

Colin Patrick McCabe commented on HDFS-4372:
--------------------------------------------

Hi Chris,

This is interesting; thanks for tackling it.

Given that we read the FSImage from a file, why not just track our current 
position in the FSImage file, plus its total size?  That would be a lot simpler 
than doing the INode number tracking.

Rather than having {{EditLogInputStream#isLengthKnown}} and 
{{EditLogInputStream#length}}, would it make more sense to throw a checked 
exception in the case where the length isn't known?  Or return a special value 
(I believe -1 is used in some cases?)  It seems like the current API is 
somewhat error-prone since someone could call length without first calling 
isLengthKnown and get an undefined result.
                
> Track NameNode startup progress
> -------------------------------
>
>                 Key: HDFS-4372
>                 URL: https://issues.apache.org/jira/browse/HDFS-4372
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-4372.1.patch, HDFS-4372.2.patch
>
>
> Track detailed progress information about the steps of NameNode startup to 
> enable display to users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to