[ 
https://issues.apache.org/jira/browse/HDFS-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13695887#comment-13695887
 ] 

Jing Zhao commented on HDFS-4372:
---------------------------------

Thanks Chris! The new patch looks pretty good to me. Only some minors:

1. For FSImageFormat#save, do we also need to change the counter value when we 
finish the saving process (the same thing done to the counter in loading)?

2. For FSImageFormat#loadXXX(), looks like the parameter step has not been 
used. Can we remove it and only add a new parameter counter?
                
> Track NameNode startup progress
> -------------------------------
>
>                 Key: HDFS-4372
>                 URL: https://issues.apache.org/jira/browse/HDFS-4372
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-4372.1.patch, HDFS-4372.2.patch, HDFS-4372.3.patch
>
>
> Track detailed progress information about the steps of NameNode startup to 
> enable display to users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to