[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709105#comment-13709105
]
Suresh Srinivas edited comment on HDFS-4979 at 7/15/13 10:52 PM:
-----------------------------------------------------------------
I noticed that where I am setting boolean {{success}} to true in try blocks is
susceptible to issues related to reordered writes. I am going to change them to
AtomicBoolean in my next patch. Any one wants to take a stab at reviewing this
patch?
bq. The above two cases are different because the return type is a
comprehensive object. Hence instead of storing the object in retry cache, it is
generated during retry attempts. In the following cases, return type is a
simple object. Hence it results in simple handling with just void, string or
boolean returned. Alternatively, at the expense of more memory we can track
returned response for create and append and simplify the code further. Any
thoughts?
In order to save some memory, should we order complexity or just hold on to the
previous response? Thoughts?
was (Author: sureshms):
I noticed that where I am setting boolean {{success}} to true in try blocks
is susceptible to issues related to reordered writes. I am going to change them
to AtomicBoolean in my next patch. Any one wants to take a stab at reviewing
this patch?
bq. The above two cases are different because the return type is a
comprehensive object. Hence instead of storing the object in retry cache, it is
generated during retry attempts. In the following cases, return type is a
simple object. Hence it results in simple handling with just void, string or
boolean returned.
In order to save some memory, should we order complexity or just hold on to the
previous response? Thoughts?
> Implement retry cache on the namenode
> -------------------------------------
>
> Key: HDFS-4979
> URL: https://issues.apache.org/jira/browse/HDFS-4979
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-4979.1.patch, HDFS-4979.2.patch, HDFS-4979.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
