[ 
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720203#comment-13720203
 ] 

Suresh Srinivas edited comment on HDFS-4979 at 7/25/13 11:08 PM:
-----------------------------------------------------------------

BTW, yesterday I meant to post this comment, and noticed I had not:

bq. It's not obvious from looking at StringUtils#getUidBytes why it must return 
an array of size 16 exactly; using a class would help.
Isn't it well know that UUID is 16 octets? Not sure a class would add any more 
clarity. However, we can add a comment where we check for the clientID size to 
clarify this. This will be done in the patch with HADOOP-9770.


                
      was (Author: sureshms):
    BTW, yesterday I meant to post this comment, and noticed I had not:

bq. It's not obvious from looking at StringUtils#getUidBytes why it must return 
an array of size 16 exactly; using a class would help.
Isn't it well know that UUID is 16 octets? Nos sure a class would add any more 
clarity. However, we can add a comment where we check for the clientID size to 
clarify this. This will be done in the patch with HADOOP-9770.


                  
> Implement retry cache on the namenode
> -------------------------------------
>
>                 Key: HDFS-4979
>                 URL: https://issues.apache.org/jira/browse/HDFS-4979
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-4979.10.patch, HDFS-4979.11.patch, 
> HDFS-4979.12.patch, HDFS-4979.1.patch, HDFS-4979.2.patch, HDFS-4979.3.patch, 
> HDFS-4979.4.patch, HDFS-4979.5.patch, HDFS-4979.6.patch, HDFS-4979.7.patch, 
> HDFS-4979.8.patch, HDFS-4979.9.patch, HDFS-4979.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to