[
https://issues.apache.org/jira/browse/HDFS-5158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763484#comment-13763484
]
Andrew Wang commented on HDFS-5158:
-----------------------------------
Hey Colin, here's a light review, I think we're waiting on ATM to give a more
thorough one:
- WATERMELON debug prints
- extra mortbay Log import in the ServerSideTranslatorPB
- Need to handle the case of null Strings being passed to listPathCacheEntries
(pool and path).
- I think it's more natural to have null be "match any path" or "match any
pool", saves some overhead too.
- hasMore, isn't it better to keep it optional in the wire format, and set a
default in the PB translators?
- DistributedFileSystem APIs take Paths, not Strings, for paths. Needs to be
resolved against the working directory too (see {{DFS#fixRelativePart}}) and
then stringified by {{getPathName}}.
- Do we normalize paths for things like a trailing slash or double slashes?
Test case for this would be cool.
- Should document the pool permissions somewhere, the CacheManager class
javadoc is very lacking right now.
- I think it's also better to stick with execute being the "list pool"
permission, but could be convinced otherwise. I get that one of read or execute
is going to be meaningless.
- Should add some DistributedFileSystem tests too, no more manual PB mangling
required now with the shiny new APIs!
- Need InterfaceStability annotations too on new classes
> add command-line support for manipulating cache directives
> ----------------------------------------------------------
>
> Key: HDFS-5158
> URL: https://issues.apache.org/jira/browse/HDFS-5158
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: HDFS-4949
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5158-caching.003.patch
>
>
> We should add command-line support for creating, removing, and listing cache
> directives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
