[
https://issues.apache.org/jira/browse/HDFS-5158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765047#comment-13765047
]
Aaron T. Myers commented on HDFS-5158:
--------------------------------------
Looking better, but still a few little issues. +1 once these are addressed:
# Need to do an s/pathCache/cacheadmin/g, and also change the description to
not mention the "path cache":
{code}
+ echo " pathCache configure the HDFS path cache"
{code}
# Pretty sure this won't work, since you changed the class name to CacheAdmin:
{code}
+ CLASS=org.apache.hadoop.hdfs.tools.PathCacheAdmin
{code}
# There's a bunch of places in comments/error messages/help messages where you
still reference a "path cache", for example:
{code}
+ * This class implements command-line operations on the HDFS Path Cache.
{code}
In the above example you should probably just remove the word "path" since this
is the more general CacheAdmin class, but in most of the cases you should
change it to "path-based cache". Just do `grep -i "path cache"' in the patch to
see what I mean.
# This patch doesn't move the already-existing cache commands into cacheadmin,
but it seems fine to me to do that in a separate JIRA.
> add command-line support for manipulating cache directives
> ----------------------------------------------------------
>
> Key: HDFS-5158
> URL: https://issues.apache.org/jira/browse/HDFS-5158
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: HDFS-4949
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5158-caching.003.patch,
> HDFS-5158-caching.004.patch, HDFS-5158-caching.005.patch,
> HDFS-5158-caching.006.patch, HDFS-5158-caching.007.patch
>
>
> We should add command-line support for creating, removing, and listing cache
> directives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
