[
https://issues.apache.org/jira/browse/HDFS-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768567#comment-13768567
]
Kousuke Saruta commented on HDFS-5206:
--------------------------------------
* DFS_STREAM_BUFFER_SIZE_KEY / DFS_STREAM_BUFFER_SIZE_DEFAULT
These are never used constants pair.
* DFS_NAMENODE_HOSTS_KEY and DFS_NAMENODE_HOSTS_EXCLUDE_KEY
These are never used constants pair. In HDFS-3209, Eli Collins mentioned.
* DFS_NAMENODE_SAFEMODE_EXTENSION_DEFAULT /
DFS_NAMENODE_REPLICATION_CONSIDERLOAD_DEFAULT /
DFS_NAMENODE_REPLICATION_CONSIDERLOAD_DEFAULT /
DFS_SERVER_HTTPS_KEYSTORE_RESOURCE_DEFAULT
Default values are hard corded although we should use these constants.
* DFS_DATANODE_HTTPS_DEFAULT_PORT
This constant is used in DFSConfigKeys.DFS_DATANODE_ADDRESS_DEFAULT
indirectly so we should keep it in the code.
* DFS_DF_INTERVAL_DEFAULT
This constant is never used and the property (dfs.df.interval) for which this
constant defined as default is used in test codes
(TestDataNodeVolumeFailureReporting.java and
TestDataNodeVolumeFailureToleration.java) and dfs.df.interval is marked as
DEPRECATED in o.a.h.c.Configuration.java
* DFS_WEB_UGI_KEY
This constant is also defined in StaticUserWebFilter.java and the property
defined by this constant is marked as DEPRECATED.
> Some unreferred constants in DFSConfigKeys should be cleanuped
> --------------------------------------------------------------
>
> Key: HDFS-5206
> URL: https://issues.apache.org/jira/browse/HDFS-5206
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Kousuke Saruta
> Assignee: Kousuke Saruta
> Priority: Minor
> Fix For: 3.0.0
>
>
> There are some constants in DFSConfigKeys.java which are no longer referred
> from any code.
> Unreferred constants are below.
> DFS_STREAM_BUFFER_SIZE_KEY
> DFS_STREAM_BUFFER_SIZE_DEFAULT
> DFS_NAMENODE_SAFEMODE_EXTENSION_DEFAULT
> DFS_NAMENODE_REPLICATION_CONSIDERLOAD_DEFAULT
> DFS_SERVER_HTTPS_KEYSTORE_RESOURCE_DEFAULT
> DFS_NAMENODE_HOSTS_KEY
> DFS_NAMENODE_HOSTS_EXCLUDE_KEY
> DFS_HTTPS_ENABLE_DEFAULT
> DFS_DATANODE_HTTPS_DEFAULT_PORT
> DFS_DF_INTERVAL_DEFAULT
> DFS_WEB_UGI_KEY
> I think we should cleanup DFSConfigKeys.java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
