[
https://issues.apache.org/jira/browse/HDFS-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768660#comment-13768660
]
Kousuke Saruta commented on HDFS-5206:
--------------------------------------
I suggest as follows.
* DFS_STREAM_BUFFER_SIZE_KEY / DFS_STREAM_BUFFER_SIZE_DEFAULT /
DFS_NAMENODE_HOSTS_KEY / DFS_NAMENODE_HOSTS_EXCLUDE_KEY
We should remove these constants from DFSConfigKeys.java
* DFS_NAMENODE_REPLICATION_CONSIDERLOAD_DEFAULT / DFS_HTTPS_ENABLE_DEFAULT /
DFS_SERVER_HTTPS_KEYSTORE_RESOURCE_DEFAULT
We should replace hard corded default value with these constants except for
test codes. In some test codes, there are hard corded default values and each
default value is different from the others.
* DFS_NAMENODE_SAFEMODE_EXTENSION_DEFAULT
We should replace hard corded default value with these constants except for
test codes and BackupNode.java. In some test codes, there are hard corded
default values and each default value is different from the others.
BackupNode.java refers dfs.namenode.safemode.extension but default value for
safemode extension is original value (Integer.MAX_VALUE) so I think we should
define a property "dfs.backupnode.safemode.extension" and constants
"DFSConfigKeys.DFS_BACKUPNODE_SAFEMODE_EXTENSION_KEY" and
"DFSConfigKeys.DFS_BACKUPNODE_SAFEMODE_EXTENSION_DEFAULT".
* DFS_DATANODE_HTTPS_DEFAULT_PORT
We should keep this constant in DFSConfigKeys.java
* DFS_DF_INTERVAL_DEFAULT
We should remove this constant from DFSConfigKeys.java and replace
DFSConfigKeys.DFS_DF_INTERVAL in TestDataNodeVolumeFailureReporting.java and
TestDataNodeVolumeFailureToleration.java with DFSConfigKeys.FS_DF_INTERFAL_KEY
and dfs.df.interval should be deprecated by fs.dfs.interval.
* DFS_WEB_UGI_KEY
We should remove this constant from DFSConfigKeys.java and replace this
constant with DFSConfigKeys.HADOOP_HTTP_STATIC_USER and dfs.web.ugi should be
deprecated by hadoop.http.staticuser.user.
> Some unreferred constants in DFSConfigKeys should be cleanuped
> --------------------------------------------------------------
>
> Key: HDFS-5206
> URL: https://issues.apache.org/jira/browse/HDFS-5206
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Kousuke Saruta
> Assignee: Kousuke Saruta
> Priority: Minor
> Fix For: 3.0.0
>
>
> There are some constants in DFSConfigKeys.java which are no longer referred
> from any code.
> Unreferred constants are below.
> DFS_STREAM_BUFFER_SIZE_KEY
> DFS_STREAM_BUFFER_SIZE_DEFAULT
> DFS_NAMENODE_SAFEMODE_EXTENSION_DEFAULT
> DFS_NAMENODE_REPLICATION_CONSIDERLOAD_DEFAULT
> DFS_SERVER_HTTPS_KEYSTORE_RESOURCE_DEFAULT
> DFS_NAMENODE_HOSTS_KEY
> DFS_NAMENODE_HOSTS_EXCLUDE_KEY
> DFS_HTTPS_ENABLE_DEFAULT
> DFS_DATANODE_HTTPS_DEFAULT_PORT
> DFS_DF_INTERVAL_DEFAULT
> DFS_WEB_UGI_KEY
> I think we should cleanup DFSConfigKeys.java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
