[
https://issues.apache.org/jira/browse/HDFS-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768572#comment-13768572
]
Colin Patrick McCabe commented on HDFS-5210:
--------------------------------------------
* RandomDataImpl can be a static object. No need to re-create it on each call
to {{randomDatanodeByRemainingCache}}
{code}
+ } else {
+ throw new IOException("Path " + directive.getPath() + " is not a
file");
{code}
This shouldn't be an exception, just a warning message. What is at the path
can change over time.
+1 once those are addressed
> Fix some failing unit tests on HDFS-4949 branch
> -----------------------------------------------
>
> Key: HDFS-5210
> URL: https://issues.apache.org/jira/browse/HDFS-5210
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: HDFS-4949
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-5210-1.patch, hdfs-5210-2.patch, hdfs-5210-3.patch
>
>
> Looking at the nightly build, looks like there are a few small errors leading
> to unit test failures.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
