[ 
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776536#comment-13776536
 ] 

Colin Patrick McCabe commented on HDFS-5191:
--------------------------------------------

bq. [import-only changes in DFSUtil.java]

fixed

bq. ...exception message would have an extraneous space

fixed

bq. Should we use GenericTestUtils#waitFor, so that there is a timeout?

fixed to use waitFor here.  even if there is an overall test timeout, it's 
nicer to use GenericTestUtils#waitFor.

I also added a comment to IdentityHashStore about the 0.50 load factor, and got 
rid of the extra slot, so hash table size is now always a power of 2.
                
> revisit zero-copy API in FSDataInputStream to make it more intuitive
> --------------------------------------------------------------------
>
>                 Key: HDFS-5191
>                 URL: https://issues.apache.org/jira/browse/HDFS-5191
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, libhdfs
>    Affects Versions: HDFS-4949
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5191-caching.001.patch, 
> HDFS-5191-caching.003.patch, HDFS-5191-caching.006.patch, 
> HDFS-5191-caching.007.patch, HDFS-5191-caching.008.patch, 
> HDFS-5191-caching.009.patch
>
>
> As per the discussion on HDFS-4953, we should revisit the zero-copy API to 
> make it more intuitive for new users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to